Provide default progress loggers and use new ProgressLogging API #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems Travis tests fail due to the same error as on master. |
|
Should the progress bars be disabled in the tests? |
|
The error on master: @pkofod did you forget to tag Optim? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #158 and adds support for the new (unreleased) support of default progress loggers in DiffEqBase to DiffEqFlux. In my local tests, progress bars were displayed in the terminal successfully (but maybe you want to disable the progress bars in the CI tests since it seems to fill up the logs IIRC).
As mentioned by @tkf in #158 (comment), the problem with the current approach of setting up the progress logs (and also in #183) is that the progress bar can't distinguish between a crashed and a slow progress. To get this right, the PR makes use of
ProgressLogging.@withprogressand the new ProgressLogging API. In this way also a UUID is used as id automatically. However, sinceProgressLogging.@withprogressautomatically initializes the progress bar before the first manual progress update (in https://github.com/JunoLab/ProgressLogging.jl/blob/b64333df0f4d2e780387af01867cccb7460da33d/src/ProgressLogging.jl#L326), a macro helps to use it only if progress output is desired. Otherwise, a progress bar might be initialized and finalized after the computations even though the user specifiedprogress = false.